Use yaml.safe_load to read the configuration #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use "yaml.safe_load" rather than the unsafe "yaml.load" to load the
configuration file.
Using bare "yaml.load" allows arbitary commands being executed from the
configuration file, which we probably don't want to allow. See the link
below for details.
This fixes the following deprecation warning:
YAMLLoadWarning: calling yaml.load() without Loader=... is
deprecated, as the default Loader is unsafe. Please read
https://msg.pyyaml.org/load for full details.
Member
Author
|
Here's the link for convenience, since GitHub didn't make it clickable in the description: https://msg.pyyaml.org/load |
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 13 13
Lines 474 474
Branches 97 97
=====================================
Hits 474 474
Continue to review full report at Codecov.
|
RauliL
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "yaml.safe_load" rather than the unsafe "yaml.load" to load the
configuration file.
Using bare "yaml.load" allows arbitary commands being executed from the
configuration file, which we probably don't want to allow. See the link
below for details.
This fixes the following deprecation warning: